)]}' { "commit": "90187bd9b6b09b1236b0e5d26676e9973e5ed2ff", "tree": "afab0910b1b37ab9de331c525e6dcb05c4bde495", "parents": [ "8c303aabb2374ae79526b27a669f06cd455be263" ], "author": { "name": "bjacob", "email": "benoitjacob@google.com", "time": "Fri Jan 20 12:52:46 2023 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Jan 20 12:52:46 2023 -0500" }, "message": "Rename away from `AArch`-everything (#11903)\n\nA number of things in LLVMCPU/ unnecessarily have references to AArch64\r\nin their names.\r\n\r\nIt\u0027s most obvious in the `setRootConfig` overload taking a `Mmt4dOp`:\r\nthis function is called regardless of architecture for any `Mmt4dOp`,\r\nand yet it ends up selecting `CPUAArchDoubleTilingExpert`:\r\nhttps://github.com/iree-org/iree/blob/a9227685614999b4de7ee53b3843ef1c7b409489/compiler/src/iree/compiler/Codegen/LLVMCPU/KernelDispatch.cpp#L993-L1038\r\n\r\nSo the chain of renamings in this PR starts here. There are multiple\r\nproblems in the name `CPUAArchDoubleTilingExpert`:\r\n1. It\u0027s suggesting something specific to ARM architectures (\"AArch\")\r\neven though it\u0027s used everywhere.\r\n2. Just `AArch` alone without a 64 or 32 suffix is not a common term.\r\n3. The `Double` part is out of sync with what the code actually does (it\r\nuses a `SingleTilingExpert`).\r\n\r\nSo, in line with other experts in the same file, we rename\r\n`CPUAArchDoubleTilingExpert` to `Mmt4dTilingExpert`. This is consistent\r\nwith the above described call site; there is only one other place that\r\ncreates that expert, that was `setAArch64RootConfig` in the same file.\r\nThat one was actually specific to `AArch64` but not Mmt4d, so the new\r\nname looks out of place here, but I think that\u0027s OK because this should\r\nonly be used in non-data-tiling on AArch64 and I think we already know\r\nthat this is going away soon.\r\n\r\nThe rest of this PR follows by similar renamings to be consistent.\r\n\r\nThis results in over-using the term `Mmt4d` a bit, since for instance\r\nthe vector lowerings only see `vector` ops such as the `vector.contract`\r\nthat result from vectorization of `mmt4d`, not the `mmt4d` themselves.\r\nBut I think that\u0027s less bad than overusing `AArch64` in code that runs\r\non all CPU architectures.\r\n\r\nVery much open to better names --- don\u0027t want to blindly jump from\r\naarch-everything to mmt4d-everything. Maybe a follow-up would reduce the\r\nnumber of separate experts, and the new name would arise for the more\r\nunified expert?", "tree_diff": [ { "type": "modify", "old_id": "4f515dbc0c7ebec62c02baf65782a4c4e4cddb4c", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/Dialect/LoweringConfig.td", "new_id": "5fad9d464e135c2638c713cc59ba66cdc2c825bc", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/Dialect/LoweringConfig.td" }, { "type": "modify", "old_id": "ddd404ea879a6d3223167a0ac53593bf234f020e", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/BUILD", "new_id": "3b596cb11dd7b772f4872925a5e29cc13a0df46f", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/BUILD" }, { "type": "modify", "old_id": "32106d3e90ddf7c6192637eb07ce84e14fb331fd", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/CMakeLists.txt", "new_id": "32652d977b26fd7276ffffe933bbf806554b3ede", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/CMakeLists.txt" }, { "type": "modify", "old_id": "bd01ef5a22aed82d417958dd0f0e9b4c47dc5bd8", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/KernelDispatch.cpp", "new_id": "484455ae72d61b517efa70fa5f3fc9c1bc8768ba", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/KernelDispatch.cpp" }, { "type": "modify", "old_id": "30c9aeaf7b1f505830882b103248610d639fd725", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/LLVMCPULowerExecutableTarget.cpp", "new_id": "503ace20995b3af4879e513f4125bed2254e00d8", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/LLVMCPULowerExecutableTarget.cpp" }, { "type": "rename", "old_id": "3912c19378dfaf02bfe4504968361c19a571d68a", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/LLVMCPUAArch64VectorLowering.cpp", "new_id": "d5bb14d8a44d23e96422747577be630972daf6d7", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/LLVMCPUMmt4dVectorLowering.cpp", "score": 94 }, { "type": "modify", "old_id": "99dc3545d2f96de7b372c3b02cbb6fdafaf0c41e", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/Passes.cpp", "new_id": "4159e418bd3b6df6ddc4b6ce722c7a73ea7b60e2", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/Passes.cpp" }, { "type": "modify", "old_id": "292c5b05d67082ff939447ad40073ecc8be81a95", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/test/aarch64_dotprod_vector_lowering.mlir", "new_id": "fa83034b968e54cdbaabd6384b287f71d300d91e", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/test/aarch64_dotprod_vector_lowering.mlir" }, { "type": "modify", "old_id": "d5e321a5f28ac3dd80844e3a488bf5dfa61213df", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/test/aarch64_vector_lowering.mlir", "new_id": "567cf48922d54a07868d21ee3b38067977a558e3", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/test/aarch64_vector_lowering.mlir" }, { "type": "modify", "old_id": "a93002f605ca41f126fcde7d5675e06263cbdf34", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/test/materialize_aarch64_launch_configuration.mlir", "new_id": "d866f1f646123bbfaf369507e39197af3f711bdb", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/test/materialize_aarch64_launch_configuration.mlir" }, { "type": "modify", "old_id": "3a99195d5099302fc3ff767075d1973ce8c91c7d", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/Passes.cpp", "new_id": "da146bc183f45796dd4537c333ac46f093ea53c7", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/Passes.cpp" }, { "type": "modify", "old_id": "0b88ce0879fc2f11f68b1be15c8fe37590714c19", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/Passes.h", "new_id": "03419b00e152492a0067b7e670832f141c889060", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/Passes.h" }, { "type": "modify", "old_id": "4ba5bccbd03b6b55ebb519d52346f54b8e8652bf", "old_mode": 33188, "old_path": "compiler/src/iree/compiler/Codegen/Passes.td", "new_id": "23b5ce8f13074f599d733754111b7970c58bbdc8", "new_mode": 33188, "new_path": "compiler/src/iree/compiler/Codegen/Passes.td" } ] }