tree a8b2faf8432edaf3fb203839946358216e7f92b3
parent d834aa7357179e0d806f3634d2efe3af2fa45171
author Max191 <44243577+Max191@users.noreply.github.com> 1726865469 -0700
committer GitHub <noreply@github.com> 1726865469 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJm7eA9CRC1aQ7uu5UhlAAAQ3wQAK8ZXjXsAyAT/9rXHRhwjqVx
 sNugCHDBQJNbizdbqT+NZ+h0hHr4/6CCYFx8p5J8D9j3on2bpv86gK8NwZwdzcY6
 N+mtuXb5LNiXYfSwbTkOal0BZ1MHRZwhwlNz/3S1pPFTNxFfuCMdKZ+A0FMRq5YO
 h9vXIno1lONetTRsILJkhgSRqqBrhg6P1q05EwoQYeZUd0r3YpvpA8ehlHSS3kTW
 oBhUbHSo/0bxBoieOV4RWPH6doUP8rZOvFG05qWk4DspZtLkNQU+DzcJMl5/uavG
 M6E+hoepAjOOvzV3rNLg9KgMXSFHFk1hwRSbMkiSS5mP4qgN9W7EdUjzVWPGluvo
 UmpipjsLzhCsNUF/FD4/W6hxmSOCwj4TNK5Li0JErwpG8TYs+4dPGIZObGrrnCYw
 G+Cdm2G3DfdmE8DyJHnxeVkzd6pSoowq1HDwY2BZWGH67bqqRK8XidOK7xg67D9G
 tZXInihmTw9PzSsDM+gVjfvdetVEBGBtkoxNhvDAVIwk2M8FbzvdTz/6ZXPnp2na
 UMFEe8Ws1TTu5D88jockDro96BlSZ1Xq0ZK0V+euvQ5uILYAvlMPk81iKBqXHApF
 xYuIrRdPXQR/dQjypmiVXwDaPtzBS8OUoGXhMVLcWaWEvywhPbQPY8xlt0XVkGtY
 yML8wFYgB8TyMuR3337s
 =iUNb
 -----END PGP SIGNATURE-----
 

[Codegen] Add control options in pack unpack decomposition (#18469)

Some early patterns in pack/unpack decomposition avoid generating
reshape ops for unit dim packs and unpacks. However, the TileAndFuse
pipeline uses these reshape ops to propagate expanded shapes to other
fusable ops. This PR adds an option to the DecomposePackUnPackOps pass
to create reshape ops anyway for unit dim cases.

The reason these unit dims show up right now is that the
iree_linalg_ext.im2col op of a unit-batched conv will have a unit
dimension in the batch dim. Ultimately, it would be good to allow for
batchless im2col ops, but in general it is good to support ops that have
required unit dimensions. When prototyping new ops, it can be easiest to
not support rank-reducing cases at first (winograd ops are another
example), so these unit dims may appear again in the future.

This PR also adds an optional control function to the pass options,
which controls which packs and unpacks get decomposed. The control
function is currently expected to be used when the `useOnlyReshapes`
option is true, since there is no control function in some upstream
patterns yet, but adding the control function upstream and fixing this
is left as a TODO.

---------

Signed-off-by: Max Dawkins <max.dawkins@gmail.com>