commit 861815cfe485592dd642088147cd01f16bb39951
author Ben Vanik <ben.vanik@gmail.com> Mon Jan 29 07:59:09 2024 -0800
committer GitHub <noreply@github.com> Mon Jan 29 07:59:09 2024 -0800
tree dfc6423ed3e34c3916c91bc0a99319713bd8062c
parent a2e983216e11259ff459e68ea027a5aea7e7feac
parent 8c7e3c93294f9ea9c9133513b5b4b710f16ef024

Switching code that can use FunctionOpInterface instead of func::FuncOp to use it. (#16220)

There's lots of tech debt around func.func, it turns out. As many uses
of func (besides creation) have been switched to the FunctionOpInterface
as a first step toward support non-func dialects. These changes will
also allow more passes to correctly operate on initializers and future
dispatch export ops that carry more information than func.func allows.
Codegen is welcome to keep using func where it wants as it's more
aligned with upstream than the rest of the compiler but there was a lot
of unnecessary coupling to func that predated the existence of the
FunctionOpInterface/CallOpInterface this cleans up.

There's a few places that still rely on func that don't really need it
but they aren't trivial to switch and the hope is that the bulk of the
cleanup here (passes, basic walks/iteration, etc) will make them easier
to burn down now that they are the exception rather than the rule.

Progress on #16187.