)]}'
{
  "commit": "84b379eeb72babd75fe097449f0e89056b78dbb5",
  "tree": "8f119bdb0e3265e674239cbb275fe6e052763c0c",
  "parents": [
    "05c9b0d230252a75ebc9322a6fbb43d0d7e8a69b"
  ],
  "author": {
    "name": "bjacob",
    "email": "benoitjacob@google.com",
    "time": "Tue Jun 20 12:01:30 2023 -0400"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Tue Jun 20 12:01:30 2023 -0400"
  },
  "message": "Fix the ukernels system build on older toolchains. (#14155)\n\nIn the process of adding the ukernels bitcode build, we dropped all\r\ncmake configure-check for toolchain support for CPU-feature-enabling\r\nflags, and configured headers. I didn\u0027t properly think through that:\r\nthat worked essentially because no one had tried building with an older\r\ntoolchain. On x86-64, that was OK because we didn\u0027t use any recent flag.\r\nbut on ARM that was more problematic with the `+i8mm` target feature.\r\n@freddan80 ran into this on\r\nhttps://github.com/openxla/iree/issues/12684.\r\n\r\nSo this brings back configure-checks and configured-headers, but only\r\nwhere they are specifically needed and not interfering with the bitcode\r\nbuild --- only in the arch/ subdirs and only in the system-build. Some\r\n`#if defined(IREE_DEVICE_STANDALONE)` lets the bitcode build opt out of\r\nincluding the configured headers.\r\n\r\nThis has a couple of side benefits. We get to drop the clumsy `#if`\u0027s\r\ntrying to do version checks on compiler version tokens, and we get to\r\nconditionally add those feature-specific dependencies instead of having\r\nthose `#if`\u0027s around the entire files, which confuse syntax highlighting\r\nwhen the feature token is not defined in the IDE build.",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "dba2b2e58004dc578c7f3d6346833254c9af6a53",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/CMakeLists.txt",
      "new_id": "138bece24630874999c9b81ddf40d59a5c43a7ad",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "1bcb60a6b48d14166aa49d75b1e9294f93dab411",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/common_arm_64.h",
      "new_id": "55c3e72627c48db5b35a168e8f622a0cf02b0ce9",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/common_arm_64.h"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "cc1143be3aca3cb47d56b4cfcc677673183d4f87",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/config_arm_64.h.in"
    },
    {
      "type": "modify",
      "old_id": "249c24ea37e985fbe09b96096adc8f6927972a30",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/mmt4d_arm_64_dotprod.c",
      "new_id": "e43f501fbc697aba94010e6efd58ac84be2afeec",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/mmt4d_arm_64_dotprod.c"
    },
    {
      "type": "modify",
      "old_id": "67054f1273e3f24d3c410f1986173f384508d14b",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/mmt4d_arm_64_i8mm.c",
      "new_id": "f31d9b9ae11a4c26b1fb879a94b59f0138f44ad7",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/arm_64/mmt4d_arm_64_i8mm.c"
    },
    {
      "type": "modify",
      "old_id": "3de1dc427cdc97c1d4b342ccb3e336208d3e565e",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/CMakeLists.txt",
      "new_id": "867d67f72f79b632e3ea0629349ba95f9e759361",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "cebd52bc0ab3023426938d46edef71942165036e",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/common_x86_64.h",
      "new_id": "59a89c38b353d3d24662d11be9ba7077e3d825c3",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/common_x86_64.h"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "3740e33ec40aca6d287827d6a32eab28f201b7cd",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/config_x86_64.h.in"
    },
    {
      "type": "modify",
      "old_id": "712c4fbdd9f5b3a8a0ef3f6cf89ad04fbf7b6297",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64.c",
      "new_id": "c5651681bb96f969c0db0e8eb06b9e69e3b7839f",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64.c"
    },
    {
      "type": "modify",
      "old_id": "0c630df4610b2de349d8a2f0d9c4d93a3d1cbdd2",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64_avx2_fma.c",
      "new_id": "29c1fcc2363938de20e9047a0626b1853861b740",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64_avx2_fma.c"
    },
    {
      "type": "modify",
      "old_id": "61262b1783a2a4c338ffc5dccbc2cd899672889a",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64_avx512_base.c",
      "new_id": "5770f7cfd8fae0430493d25f42c315e0ee53a05d",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64_avx512_base.c"
    },
    {
      "type": "modify",
      "old_id": "9006567c234f78e0be29ebc0ad5e98214ab07f11",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64_avx512_vnni.c",
      "new_id": "0066d8b7e659a0fc30c42733f58fb5d425597f65",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64_avx512_vnni.c"
    },
    {
      "type": "modify",
      "old_id": "6c06b888c0aec568fe35713548994f82f84d16fa",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/pack_x86_64.c",
      "new_id": "74361c99e95393cb1db49f02c7cf66f1d976a00f",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/pack_x86_64.c"
    },
    {
      "type": "modify",
      "old_id": "55e41cf9545f08ce230b4900c5271cc5457247fd",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/pack_x86_64_avx2_fma.c",
      "new_id": "2ef88178ed520324da15daf4437be0bf9bfdedc8",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/pack_x86_64_avx2_fma.c"
    },
    {
      "type": "modify",
      "old_id": "44a3dc3944bbf3dcf176083811248d9f43c11a64",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/pack_x86_64_avx512_base.c",
      "new_id": "29ad77e8de603bf65314cdbe762dd92cb3a7bcfa",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/pack_x86_64_avx512_base.c"
    },
    {
      "type": "modify",
      "old_id": "2efbc66625bb0acb58c2ec73e6421b7d3da65a4b",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/query_tile_sizes_x86_64.c",
      "new_id": "72b54e0ddf41441380c55b228cd5dbb1f19cd214",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/query_tile_sizes_x86_64.c"
    },
    {
      "type": "modify",
      "old_id": "bc57b3755a4bafdbcb0495bb16f40dd1a4a3725a",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/unpack_x86_64.c",
      "new_id": "dd768b216a15e58eb4f278bd636f8fc4ee0bf8da",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/unpack_x86_64.c"
    },
    {
      "type": "modify",
      "old_id": "cc2600d1092a0030d86644939088379b34caa5ea",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/unpack_x86_64_avx2_fma.c",
      "new_id": "1adcc07cc095c617555587890873a62a817e912e",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/unpack_x86_64_avx2_fma.c"
    },
    {
      "type": "modify",
      "old_id": "2c9229d0dcfacd1902999063cdc60441b65084cc",
      "old_mode": 33188,
      "old_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/unpack_x86_64_avx512_base.c",
      "new_id": "256cf0e75a5bd931142992566440288226af88ee",
      "new_mode": 33188,
      "new_path": "runtime/src/iree/builtins/ukernel/arch/x86_64/unpack_x86_64_avx512_base.c"
    }
  ]
}