Always remove temorary directory used for benchmarking on the host (#8643)
This avoids lingering artifacts when we have failed benchmark runs,
which can use out of storage issue sometimes.
diff --git a/build_tools/benchmarks/run_benchmarks_on_android.py b/build_tools/benchmarks/run_benchmarks_on_android.py
index a5a9209..7763cf2 100755
--- a/build_tools/benchmarks/run_benchmarks_on_android.py
+++ b/build_tools/benchmarks/run_benchmarks_on_android.py
@@ -756,6 +756,8 @@
atexit.register(execute_cmd_and_get_output,
["adb", "shell", "rm", "-rf", ANDROID_TMP_DIR],
verbose=args.verbose)
+ # Also clear temporary directory on the host device.
+ atexit.register(shutil.rmtree, args.tmp_dir)
# Tracy client and server communicate over port 8086 by default. If we want
# to capture traces along the way, forward port via adb.
@@ -824,10 +826,6 @@
for capture_filename in captures:
tar.add(capture_filename)
- # Delete all the temp files if everything completed successfully.
- if not args.no_clean and not errors:
- shutil.rmtree(args.tmp_dir)
-
if errors:
print("Benchmarking completed with errors", file=sys.stderr)
raise RuntimeError(errors)
