commit | 688497c65a823cc5c885dd6be7fed70afd71a42c | [log] [tgz] |
---|---|---|
author | bjacob <benoitjacob@google.com> | Thu Sep 22 15:56:11 2022 -0400 |
committer | GitHub <noreply@github.com> | Thu Sep 22 19:56:11 2022 +0000 |
tree | 676f6d86a5a33badd309145b5fb47ba9ecc5f5af | |
parent | ca85396d9990293c5456f7da5fc71cc5906eca0c [diff] |
Accept EINTR (interrupted by signal) futex return code (#10517) This loop is already handling EAGAIN. It looks like it should handle EINTR the same way. I'm trying to guess what might cause the intermittent crash #10337. One thing that would explain it is if the iree_task_scope_wait_idle done at the end of SubmitTasksAndWaitIdle wasn't doing its job. It calls iree_notification_await, which assumes that iree_notification_commit_wait never returns false unless the deadline is exceeded. But iree_notification_commit_wait does return false if the futex syscall returns an expected error code, so we need to handle the exhaustive list of return codes that might come out of this syscall. The manual page lists only very few possible return codes for the particular FUTEX_WAIT op we're doing here (there are plenty of error cases, but few apply to FUTEX_WAIT). EINTR is the only one that I could see us missing here.
IREE (Intermediate Representation Execution Environment, pronounced as “eerie”) is an MLIR-based end-to-end compiler and runtime that lowers Machine Learning (ML) models to a unified IR that scales up to meet the needs of the datacenter and down to satisfy the constraints and special considerations of mobile and edge deployments.
See our website for project details, user guides, and instructions on building from source.
IREE is still in its early phase. We have settled down on the overarching infrastructure and are actively improving various software components as well as project logistics. It is still quite far from ready for everyday use and is made available without any support at the moment. With that said, we welcome any kind of feedback on any communication channels!
See our website for more information.
IREE is licensed under the terms of the Apache 2.0 License with LLVM Exceptions. See LICENSE for more information.