commit 5470316bfa494de55d2f26d9d22c9c5fcf5b960a
author Ben Vanik <benvanik@google.com> Thu Mar 03 20:23:28 2022 -0800
committer Ben Vanik <benvanik@google.com> Fri Mar 04 11:52:21 2022 -0800
tree a2ec528bc27d9cf9c409fed8014cc2bc131e07e6
parent d57338696118b907197bf1a551fd3e215af8dfd3

Fail with an error if attempting to serialize an unknown attr.

iree/compiler/Dialect/Util/IR/UtilAttrs.cpp

diff --git a/iree/compiler/Dialect/Util/IR/UtilAttrs.cpp b/iree/compiler/Dialect/Util/IR/UtilAttrs.cpp
index 370a1df..c519b6b 100644
--- a/iree/compiler/Dialect/Util/IR/UtilAttrs.cpp
+++ b/iree/compiler/Dialect/Util/IR/UtilAttrs.cpp
@@ -462,6 +462,11 @@
                                                llvm::raw_ostream &os) const {
   for (auto valueAttr : getValues()) {
     auto serializableAttr = valueAttr.dyn_cast<SerializableAttrInterface>();
+    if (!serializableAttr) {
+      llvm::errs() << "unable to serialize a non-serializable attribute: "
+                   << valueAttr.getType() << "\n";
+      return failure();
+    }
     if (failed(serializableAttr.serializeToStream(endian, os))) {
       return failure();
     }