commit 47dfaa54c2cae59323a43d7c001a693090cd1c78
author James Newling <james.newling@gmail.com> Fri Mar 08 08:15:02 2024 -0800
committer GitHub <noreply@github.com> Fri Mar 08 08:15:02 2024 -0800
tree 181635683448f1d756b59e7ca3454081e38044d1
parent 7884dc8a2009d86b809161dffbb6ac8c2b68bdf0

If negative tolerance in numerical test, then emit error (#16694)

Numpy:


![image](https://github.com/openxla/iree/assets/4902987/1f60a82d-83d8-4a76-b1fc-ecf011f90c7a)

My sanity check in iree-amd-aie of setting a negative tolerance failed,
leaving me unsure if something else in the backend wasn't working.

tools/iree-e2e-matmul-test.cc

diff --git a/tools/iree-e2e-matmul-test.cc b/tools/iree-e2e-matmul-test.cc
index e165830..2f73082 100644
--- a/tools/iree-e2e-matmul-test.cc
+++ b/tools/iree-e2e-matmul-test.cc
@@ -583,6 +583,15 @@
         iree_make_status(IREE_STATUS_INVALID_ARGUMENT, "mismatched types"));
     return false;
   }
+
+  if (FLAG_acceptable_fp_delta < 0.0f) {
+    iree_status_abort(
+        iree_make_status(IREE_STATUS_INVALID_ARGUMENT,
+                         "negative tolerance (acceptable_fp_delta=%.8g)",
+                         FLAG_acceptable_fp_delta));
+    return false;
+  }
+
   switch (expected.type) {
     case IREE_E2E_TEST_VALUE_TYPE_I32:
       return actual.i32 == expected.i32;