)]}'
{
  "commit": "39f1e8b2d98550d987a35e0f4dfa839710965ae3",
  "tree": "e7bb915499cc6d942f6257b8c521a71cc3b9f3ca",
  "parents": [
    "c1557b10d666803fe1aac3903fa685fd7986ff66"
  ],
  "author": {
    "name": "Nicolas Vasilache",
    "email": "nicolasvasilache@users.noreply.github.com",
    "time": "Mon Mar 20 05:05:06 2023 -0400"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Mon Mar 20 10:05:06 2023 +0100"
  },
  "message": "Avoid FunctionalStyleTransformOpTrait where unnecessary to improve u… (#12681)\n\n…sability\r\n\r\nThis PR simplifies most transforms that return the same handle that they\r\nwere passed without modifying the op itself. The chaining behavior\r\nresults in too much cognitive overhead when manipulating transform\r\nscripts as handle names need to constantly be updated as soon as a\r\ntransform is disabled or moved. Instead, avoid consuming the handle\r\nwherever possible.",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "85e6ddfa3af787de16225f0eadf49d92e4247343",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/Common/TransformExtensions/CommonExtensions.cpp",
      "new_id": "48a94c7654aca2462e9ce0049edf42a0078a78df",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/Common/TransformExtensions/CommonExtensions.cpp"
    },
    {
      "type": "modify",
      "old_id": "e806ec61fc727930c99dddba2d572c8e77939516",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/Common/TransformExtensions/CommonExtensionsOps.td",
      "new_id": "faeed4fe8eab14d08abc99627b20800b6782c4a6",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/Common/TransformExtensions/CommonExtensionsOps.td"
    },
    {
      "type": "modify",
      "old_id": "6131ead0e569ed852b886edcf1c5be944763356f",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/Common/test/reductions_codegen_spec.mlir",
      "new_id": "f36d976b35798ca583df236bc7ff5e885ca66a31",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/Common/test/reductions_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "ef59dd5c14cb4fe75d34fd65d33daedafc1a6e37",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/Common/test/transform_buffer_opt.mlir",
      "new_id": "f7949cabb58b853be5004f7184ef473a8b386f25",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/Common/test/transform_buffer_opt.mlir"
    },
    {
      "type": "modify",
      "old_id": "c3eebc0a43eb10782e2d6f04b73198ee3d695b85",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/Common/test/transform_dialect_apply_pattern_op.mlir",
      "new_id": "4c0282fa1fbc18555776da954b38bbd96a49e476",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/Common/test/transform_dialect_apply_pattern_op.mlir"
    },
    {
      "type": "modify",
      "old_id": "9268b1777b5d980155e5a3bcaed8291af5998e11",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/test/transform_dialect_bufferize.mlir",
      "new_id": "147e694ccaae2d0bcab02cea043c0b8aaea6be10",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/test/transform_dialect_bufferize.mlir"
    },
    {
      "type": "modify",
      "old_id": "d9cce5deac6bb12c54687cfff9203642c8907950",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/test/transform_dialect_iree_tile_to_forall.mlir",
      "new_id": "2db37f5243310f1751c9f6d196774ba6f15a3c6a",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMCPU/test/transform_dialect_iree_tile_to_forall.mlir"
    },
    {
      "type": "modify",
      "old_id": "ad925ada7cc374a8c9cfc529e02cc3bfb1192853",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/TransformExtensions/LLVMGPUExtensions.cpp",
      "new_id": "ce3393df9db760889fe523e5503a9379f0b0808b",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/TransformExtensions/LLVMGPUExtensions.cpp"
    },
    {
      "type": "modify",
      "old_id": "82f4797d8fc0faca8e7cb4e98dd0f20268f755fc",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/TransformExtensions/LLVMGPUExtensionsOps.td",
      "new_id": "34e4d38bb2bbb1906d00daadf01189a1b47a9699",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/TransformExtensions/LLVMGPUExtensionsOps.td"
    },
    {
      "type": "modify",
      "old_id": "e96b768d2c6b3cb066eb6d2308880f6793aa10e2",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/create_async_groups.mlir",
      "new_id": "30aa09c8f868768f97f70b642c43cf4f550bc992",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/create_async_groups.mlir"
    },
    {
      "type": "modify",
      "old_id": "4913b209ad58204920a800371262773156abfe06",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/set_transform_strategy.mlir",
      "new_id": "67ee3d0f19a1b256e6143c636e084ffaba6874af",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/set_transform_strategy.mlir"
    },
    {
      "type": "modify",
      "old_id": "02ec5bbbc0cabb4205d3e6215c562ad9a88fc5b3",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_bufferize.mlir",
      "new_id": "accc2c146a15d9e1443de20f2094d3b0a4d987d3",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_bufferize.mlir"
    },
    {
      "type": "modify",
      "old_id": "87d7bb30833d845f2023ac023a30cafa86ba6b32",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_codegen_bufferize_spec.mlir",
      "new_id": "cbcd1e24e428a63370e5ec30d2b58fa9fea05680",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_codegen_bufferize_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "4314ef1bf07a1afc36e778f8632e42261cfae19d",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_codegen_foreach_to_gpu_spec.mlir",
      "new_id": "167798c78058c3e6a39a79bf1ea2c22f989504f9",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_codegen_foreach_to_gpu_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "7f438dac8d7f4eeea45ebb43c534067fc42c648a",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_codegen_vector_distribution_spec.mlir",
      "new_id": "adeceaff7d4b5c12a16c2a840e815dd4aa210f82",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_codegen_vector_distribution_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "ac01b4389380c4105fa417b4afcf232cf29af46e",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_codegen_vector_warp_execute_on_lane_0_spec.mlir",
      "new_id": "c5fe39a705390868cfe8585e3066433ed2581f0d",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_codegen_vector_warp_execute_on_lane_0_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "cabc06ba126565637217fb769b506951e72db3c5",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_hoist_allocs.mlir",
      "new_id": "93c9f34f77147777e57a3de978f30853446fbf34",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_hoist_allocs.mlir"
    },
    {
      "type": "modify",
      "old_id": "f5372f9d35ffe048f59d87f7ffc577a4046fd596",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_promote_operands.mlir",
      "new_id": "6bc9562ac34a68f8433dae1e233c63be90abccb9",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_dialect_promote_operands.mlir"
    },
    {
      "type": "modify",
      "old_id": "c9539f3956b4011d5f2cf6f2e655073a77a0da9a",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_distribute_forall.mlir",
      "new_id": "4173942d171cc445d652853fa81d9037da5a64e4",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_distribute_forall.mlir"
    },
    {
      "type": "modify",
      "old_id": "cf54d3d6e6b7403588d8a6e29358d9bcb0d887eb",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_vector_to_mma.mlir",
      "new_id": "65f6f0a2ff14d1059c62ac1f098468d5a2d36196",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/transform_vector_to_mma.mlir"
    },
    {
      "type": "modify",
      "old_id": "885ab506f47ea6ef29e98c10402eb399b191f4c8",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/workgroup_specialization_pipeline_test.mlir",
      "new_id": "6409dece37e42febce041bcf12ec7de42c12e9f8",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/LLVMGPU/test/workgroup_specialization_pipeline_test.mlir"
    },
    {
      "type": "modify",
      "old_id": "e5bf9946210f8a44bbd5253ff97dae0d4fe2e52c",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/TransformDialectStrategies/CPU/Common.cpp",
      "new_id": "36897225607b95200aa708d257c665b448f03a0d",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/TransformDialectStrategies/CPU/Common.cpp"
    },
    {
      "type": "modify",
      "old_id": "dbddae94c7066a938b17f1c991b5992b7d922554",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/TransformDialectStrategies/Common/Common.cpp",
      "new_id": "a86dc79765858d58e06dec0c1fd59134208fee08",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/TransformDialectStrategies/Common/Common.cpp"
    },
    {
      "type": "modify",
      "old_id": "6802b3d715fc9be1cb364e11a2b53b585910d952",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/TransformDialectStrategies/GPU/Common.cpp",
      "new_id": "408ebc5c6d79bafeb976f7b451facbf42d9dbed1",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/TransformDialectStrategies/GPU/Common.cpp"
    },
    {
      "type": "modify",
      "old_id": "17f95e90841597845f53b837873573ceeb1f4280",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/TransformDialectStrategies/GPU/SmallReductionStrategy.cpp",
      "new_id": "66eaecae8a06bbbd2b1b45969648990ac03e7127",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/TransformDialectStrategies/GPU/SmallReductionStrategy.cpp"
    },
    {
      "type": "modify",
      "old_id": "131a9abdea52eddf039bf07c013a836ae09b5d14",
      "old_mode": 33188,
      "old_path": "compiler/src/iree/compiler/Codegen/TransformDialectStrategies/GPU/StagedReductionStrategy.cpp",
      "new_id": "5c3e19f0427acb802670d25ad8d06f68c00adb48",
      "new_mode": 33188,
      "new_path": "compiler/src/iree/compiler/Codegen/TransformDialectStrategies/GPU/StagedReductionStrategy.cpp"
    },
    {
      "type": "modify",
      "old_id": "20297024f62cf85acb18e564d06c8dc076d189f1",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cpu/matmul_codegen_custom_dispatch_formation_spec.mlir",
      "new_id": "9ea53e2b9677de4cd5c145d85e76e418f008fb54",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cpu/matmul_codegen_custom_dispatch_formation_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "c7f1491f211887c7752419ad8304a309cfb8c4d6",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cpu/matmul_codegen_default_spec.mlir",
      "new_id": "d2e432db293728a4f8a8d250040e2b84e94f4b6c",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cpu/matmul_codegen_default_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "e39aed55e8f825a0b3e4150330413d5551035584",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/eltwise_reduction_codegen_spec.mlir",
      "new_id": "7fa9a71aa0bd3788b3dee9f6b141d45b03267daf",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/eltwise_reduction_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "bd5115c71cb8614f3990305e77aa1bad47df7271",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/eltwise_reduction_eltwise_codegen_spec.mlir",
      "new_id": "12e549d75eb9766d6683242fdbed3ac9fd59c14b",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/eltwise_reduction_eltwise_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "6dc2e7dfbfd7c238e2bcd29eb3fa7404205bf98e",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/mma.mlir",
      "new_id": "ae8dce9af063ce78de178df70eb2f430ef49be91",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/mma.mlir"
    },
    {
      "type": "modify",
      "old_id": "e47235f662ed23f39fe6ceb885cf799bb61f8931",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/mma_using_layout_analysis_codegen_spec.mlir",
      "new_id": "8bdad3f0f0eaaac975355e8a03ab6ea1458b7bdf",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/mma_using_layout_analysis_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "e4c2f0ae06796797355f630323f82b7cfa7cb292",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/reduction_codegen_spec.mlir",
      "new_id": "16ae5891654653e1ab8c8b2b834f4d1b6c996e43",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/reduction_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "164cd31cbbb4983dc6e06d5068fdae4f89a12eea",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/reduction_eltwise_codegen_spec.mlir",
      "new_id": "738aa51a9afd63570a72d669e89e17d0663c1ddb",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/reduction_eltwise_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "bda3fcb94da438fc5666ac15f6699e5d376396a9",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/reduction_v2_codegen_spec.mlir",
      "new_id": "b399e47c610feed1f891fa2a8c60142ff06bdcb1",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/reduction_v2_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "a240e7ba24580dae0eec1f8686e02aca1d51d9a9",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/reduction_v3_codegen_spec.mlir",
      "new_id": "899613d21967c54a27bdd9bec1882724ea3003ae",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/reduction_v3_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "8e8d40ce3402806539a0f36b8866abba598165b9",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/softmax_codegen_spec.mlir",
      "new_id": "7c3c816e1b7f57a6570177dd6395d18d315a787f",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/softmax_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "3e7d96a6e4cf0b3909bafcab2d8c9b32d899458b",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/softmax_partial_codegen_spec.mlir",
      "new_id": "b87848568edc670be30775800a03552bcf45456b",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/softmax_partial_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "986076421f2fa2f80f7407d227785bdc76feb003",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/softmax_v2_codegen_spec.mlir",
      "new_id": "1ac9386fa0b481de2b1acd667212df54ca5eb53b",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/softmax_v2_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "ee202ad909c21dea3e37946d61416e60a53b1b11",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/vecadd2d_codegen_spec.mlir",
      "new_id": "aefe3b30538045c02524de4cbf8e9e5610c9fe1c",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/vecadd2d_codegen_spec.mlir"
    },
    {
      "type": "modify",
      "old_id": "86869682e28173323772998d90f2c61f8f4d8ad1",
      "old_mode": 33188,
      "old_path": "tests/transform_dialect/cuda/vecadd2d_codegen_spec_partial_tile.mlir",
      "new_id": "8bad45e15eafb5d605b588228fd4553f420fe6ea",
      "new_mode": 33188,
      "new_path": "tests/transform_dialect/cuda/vecadd2d_codegen_spec_partial_tile.mlir"
    }
  ]
}