commit 1ea21d1acf22b090126eb3d297b875f9072dfefe
author Scott Todd <scott.todd0@gmail.com> Fri Jun 14 19:55:10 2024 -0700
committer GitHub <noreply@github.com> Fri Jun 14 19:55:10 2024 -0700
tree 93aabaa7f39d8e05b6072763f80bff62fd227fb6
parent c5d4b96a4aadbc86c6b63052e900adbc88037d38

Fix hip dynamic_symbols_test to check min version. (#17674)

Progress on https://github.com/iree-org/iree/issues/17370

ci-exactly: build_all, test_amd_mi250

runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc

diff --git a/runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc b/runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc
index fe64ab9..87f075e 100644
--- a/runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc
+++ b/runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc
@@ -87,9 +87,11 @@
     GTEST_SKIP() << "HIP RCCL symbols cannot be loaded, skipping test.";
   }
 
+  // Check that the loaded version is at least the version we compiled for.
   int nccl_version = 0;
   NCCL_CHECK_ERRORS(nccl_symbols.ncclGetVersion(&nccl_version));
-  ASSERT_EQ(NCCL_VERSION_CODE, nccl_version);
+  ASSERT_GE(nccl_version, NCCL_VERSION_CODE);
+
   iree_hal_hip_nccl_dynamic_symbols_deinitialize(&nccl_symbols);
   iree_hal_hip_dynamic_symbols_deinitialize(&hip_symbols);
 }