)]}'
{
  "commit": "189bfeed5885a8752ea0b860afd53b80d053b49d",
  "tree": "851065f11cc4f909c0ba72f4974d0ffc378e3496",
  "parents": [
    "18a14e91e847868d5abed4e6e7a0234ef9c0dcbd"
  ],
  "author": {
    "name": "Denis Khalikov",
    "email": "khalikov.denis@huawei.com",
    "time": "Mon Jan 06 15:07:08 2020 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Mon Jan 06 15:08:10 2020 -0800"
  },
  "message": "[hal][vulkan] Add a missing allocation for descriptor set.\n\nDo not forget to allocate descriptor set from a newly created descriptor\npool in case previous one was out of the memory.\n\nError for mnist.mlir test:\n```\n$ export VK_INSTANCE_LAYERS\u003dVK_LAYER_LUNARG_core_validation\n$ iree-run-mlir test/e2e/xla/mnist.mlir -iree-hal-target-backends\u003dvulkan-spirv -input-value\u003d\"1x28x28x1xf32\"\n```\n\nError message:\n```\niree/hal/vulkan/debug_reporter.cc:40] Unable to allocate 3 descriptors of type VK_DESCRIPTOR_TYPE_STORAGE_BUFFER from pool 0x59. This pool only has 1 descriptors of this type remaining. The Vulkan spec states: descriptorPool must have enough free descriptor capacity remaining to allocate the descriptor sets of the specified layouts (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-VkDescriptorSetAllocateInfo-descriptorPool-00307)\nE iree/hal/vulkan/debug_reporter.cc:40] Cannot call vkUpdateDescriptorSets() on descriptor set 0x0 that has not been allocated.\nE iree/hal/vulkan/debug_reporter.cc:40] Cannot call vkUpdateDescriptorSets() on descriptor set 0x0 that has not been allocated.\nE iree/hal/vulkan/debug_reporter.cc:40] Cannot call vkUpdateDescriptorSets() on descriptor set 0x0 that has not been allocated.\nE iree/hal/vulkan/debug_reporter.cc:40] vkUpdateDescriptorSets: required parameter pDescriptorWrites[0].dstSet specified as VK_NULL_HANDLE\nE iree/hal/vulkan/debug_reporter.cc:40] vkUpdateDescriptorSets: required parameter pDescriptorWrites[1].dstSet specified as VK_NULL_HANDLE\nE iree/hal/vulkan/debug_reporter.cc:40] vkUpdateDescriptorSets: required parameter pDescriptorWrites[2].dstSet specified as VK_NULL_HANDLE\n```\n\nCloses #394\n\nCOPYBARA_INTEGRATE_REVIEW\u003dhttps://github.com/google/iree/pull/394 from denis0x0D:sandbox/hal_vulkan_des_pool ebed04074ca09a812ecdfe679803ecc4bf7422bc\nPiperOrigin-RevId: 288384334\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "636cfcd923005328fa747758b824530cd3391d6d",
      "old_mode": 33188,
      "old_path": "iree/hal/vulkan/descriptor_set_arena.cc",
      "new_id": "3b19ee003bb5afa2419937cc4f0a43b70ecf288a",
      "new_mode": 33188,
      "new_path": "iree/hal/vulkan/descriptor_set_arena.cc"
    }
  ]
}