)]}'
{
  "commit": "b683bd76fed4b9d026a1b7827dd0f35d67b1c450",
  "tree": "7c97ebfac490a91804c821fd497894cc97752af4",
  "parents": [
    "7c3843df31022bcbc11c53f5dbed9002276899a0"
  ],
  "author": {
    "name": "Rupert Swarbrick",
    "email": "rswarbrick@lowrisc.org",
    "time": "Tue Apr 05 17:25:47 2022 +0100"
  },
  "committer": {
    "name": "Rupert Swarbrick",
    "email": "rswarbrick@gmail.com",
    "time": "Thu Apr 07 14:30:28 2022 +0100"
  },
  "message": "[otbn,rtl] Make sure to latch \"non-core\" error bits\n\nI think I probably broke this in 75885e6. If you look at e.g.\notbn_core.sv, you\u0027ll see that we have err_bits_q and err_bits_d and we\nlatch errors until the next start signal.\n\nI thought that I\u0027d done the same thing in otbn.sv for errors that\ndon\u0027t come from the core, but I really hadn\u0027t! There, err_bits,\nerr_bits_d and err_bits_q are used to make sure that we only update\nthe (hwext) ERR_BITS register when a command finishes. That\u0027s fine for\nsignals coming out of the core because (as mentioned above) we latch\nthem there. But it isn\u0027t fine for signals generated at top-level.\n\nNote that, unlike the other \"error bits\" registers, we don\u0027t bother\nincluding a provision for clearing them. This is because all of the\nsignals are fatal so we should never be able to start another\noperation (clearing the error bits) anyway.\n\nSigned-off-by: Rupert Swarbrick \u003crswarbrick@lowrisc.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "af6f26e18e0ef15433bd34d9abc7667d17d0ec2a",
      "old_mode": 33188,
      "old_path": "hw/ip/otbn/rtl/otbn.sv",
      "new_id": "15f6ec6ace0ef04f370ec01d41932afb8e8cf7f7",
      "new_mode": 33188,
      "new_path": "hw/ip/otbn/rtl/otbn.sv"
    },
    {
      "type": "modify",
      "old_id": "0ea4ddea3a1d8159033ad5450b0ac6c679b0e7d5",
      "old_mode": 33188,
      "old_path": "hw/ip/otbn/rtl/otbn_pkg.sv",
      "new_id": "017aae020b6f0b39b19f11c601c723ece908548a",
      "new_mode": 33188,
      "new_path": "hw/ip/otbn/rtl/otbn_pkg.sv"
    }
  ]
}