)]}'
{
  "commit": "7af9f1a0bc7ea2754bf41e0ef309223c837ec0df",
  "tree": "fe67d7900702cedd1269da001c2364337ebda8d9",
  "parents": [
    "620a9d1b32a73d9c35f859e04eddc99d36cc04f9"
  ],
  "author": {
    "name": "Rupert Swarbrick",
    "email": "rswarbrick@lowrisc.org",
    "time": "Fri Mar 04 12:05:48 2022 +0000"
  },
  "committer": {
    "name": "Rupert Swarbrick",
    "email": "rswarbrick@gmail.com",
    "time": "Sat Mar 05 18:36:23 2022 +0000"
  },
  "message": "[keymgr,dv] Fix some enum casting problems\n\nThe cast that we add in keymgr_scoreboard.sv to current_op_status is\nto silence warnings from Xcelium where you have to be explicit about\nconverting from an integral type to an enum. Here, we know that the\nconversion is safe because we\u0027ve just checked that the value equals\nOpDoneSuccess or OpDoneFail.\n\nThe other two changes also fix Xcelium warnings, but possibly change\nthe meaning of the code (for the better!). For example, in\nkeymgr_base_vseq, we are reading a 3-bit register. We were then\nforcing it to be of type keymgr_ops_e, but that enum doesn\u0027t actually\nhave an item for the bit pattern 3\u0027b111. Fortunately, we only ever use\nthe result to compare it with enum values so we can just store the\nintegral value instead, avoiding the cast. The only need for the\n\"cast_operation\" variable is now to generate a debug message.\n\nThe same argument applies to current_design_state (which is used as an\noutput parameter to csr_rd).\n\nSigned-off-by: Rupert Swarbrick \u003crswarbrick@lowrisc.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d4a7f888942710eb7c6d069fa282fd9f17bd80c2",
      "old_mode": 33188,
      "old_path": "hw/ip/keymgr/dv/env/keymgr_scoreboard.sv",
      "new_id": "4ac6ee4e6677b5ddd38639ed33b3fe0797e575c7",
      "new_mode": 33188,
      "new_path": "hw/ip/keymgr/dv/env/keymgr_scoreboard.sv"
    },
    {
      "type": "modify",
      "old_id": "8bcbbabb64ae4798aedb24a5e83c719f25b4c6b1",
      "old_mode": 33188,
      "old_path": "hw/ip/keymgr/dv/env/seq_lib/keymgr_base_vseq.sv",
      "new_id": "d291719e366d013bd533ff8658680f78c77e8bae",
      "new_mode": 33188,
      "new_path": "hw/ip/keymgr/dv/env/seq_lib/keymgr_base_vseq.sv"
    }
  ]
}