tree b98c9fe5f6c90461eb1ee41fb43f310cdfd0b0b2
parent ec62b3e078e437e9c2c5c9ae20276a89681dd156
author Rupert Swarbrick <rswarbrick@lowrisc.org> 1587717875 +0100
committer weicaiyang <49293026+weicaiyang@users.noreply.github.com> 1588008884 -0700

[dvsim] PEP8 fixes in dvsim

These should cause no functional change. Detailed list of code changes:

  - Get rid of 'import *': this defeats static analysis tools. Don't
    do it.

  - Add newline after colon in "if foo: bar"

  - Use 'is' to check for equality with boolean literals

  - Don't catch exceptions when running os.system in Deploy.py: the
    os.system function returns the program's exit code.

  - Delete some variables that are written but not read.

  - Minor whitespace changes (missing blank lines between functions;
    weird indentation; missing space after '#')

  - Delete autogenerated module docstrings (they didn't contain any
    information. Maybe it would be good to have a docstring, but at
    the moment it's just noise).

  - Don't use \ as a line continuation character. Use parentheses if
    necessary.

  - Replace code like "foo" + \ "bar" with just "foo" "bar" (Python
    concatenates adjacent string literals just like C). (I didn't do
    this everywhere, but it happened a lot next to the backslash
    continuations, so I got rid of the unnecessary '+' then).

  - Replace "not foo in bar" with "foo not in bar"

  - Use raw strings for regexes with backslashes (r'a\+', not 'a\+')

With these changes, you can run:

  find util/dvsim -name '*.py' | xargs flake8

and see no errors.

Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>