)]}' { "commit": "563312c8cabd3f135c58df639634e741e241d638", "tree": "d6b8181e0661f199de5c2f53bae7f6a230cf664e", "parents": [ "76f35f4bc2d6304aed1112fc3a3734bf135ac083" ], "author": { "name": "Timothy Trippel", "email": "ttrippel@google.com", "time": "Wed Feb 02 15:10:28 2022 -0800" }, "committer": { "name": "Timothy Trippel", "email": "5633066+timothytrippel@users.noreply.github.com", "time": "Tue Feb 08 22:57:58 2022 -0800" }, "message": "[sw/ottf] Rename test_rom_ext to ottf_start\n\nPreviously the boot sequence for chip level tests looked like:\n\nchip reset --\u003e test_rom --\u003e test_rom_ext --\u003e ottf --\u003e test_main()\n\nIn the above sequence the `test_rom_ext` was really just an ASM file\nthat performed initializations prior to jumping to the OTTF `main()`.\nHowever, as we refactor the OTTF to enable running chip-level tests at\nvarious boot stages (e.g., ROM_EXT and BL0, see #10498), it makes more\nsense to model the combined OTTF and test bundle as its own boot stage\nthat can be run in inplace of the ROM_EXT or BL0.\n\nTherefore, this commit renames/consolidates the test_rom_ext into a\ncomponent of the OTTF, called the `ottf_start`. The `ottf_start` is kept\nas a separate static library from the `ottf` to enable running tests\nthat do not use the OTTF, i.e. the crt_test (which tests the\nfunctionality of the `ottf_start` library), and the \"Hello World\"\nexample programs. However, when test images are built, both the\n`ottf_start` and `ottf` are linked with the test library itself, to\ncreate one cohesive \"test boot stage\".\n\nThe new boot sequence for a test will look like:\n\nchip reset --\u003e test_rom --\u003e ottf --\u003e test_main(),\n\nwhere OTTF \u003d (ottf_start --\u003e OTTF).\n\nThis partially addresses a task in #10498.\n\nSigned-off-by: Timothy Trippel \u003cttrippel@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "54cbca3f5e792e26bff83298657cb11d3d79c4ea", "old_mode": 33188, "old_path": "hw/top_englishbreakfast/util/sw_sources.patch", "new_id": "2a93e3f766d5e7707a8535a554b08847ef017f85", "new_mode": 33188, "new_path": "hw/top_englishbreakfast/util/sw_sources.patch" }, { "type": "modify", "old_id": "d8633f451e6cde9213989bb75d627ca582a2a346", "old_mode": 33188, "old_path": "rules/opentitan.bzl", "new_id": "48f1647fa74f97097d48c2582982c5d64f9ecee2", "new_mode": 33188, "new_path": "rules/opentitan.bzl" }, { "type": "modify", "old_id": "c2552594894a822e4d8ee003c7462ce204a64df5", "old_mode": 33188, "old_path": "sw/device/benchmarks/coremark/meson.build", "new_id": "bee242f3fae5a1e8b63f6eda2b06f0cbf37720ca", "new_mode": 33188, "new_path": "sw/device/benchmarks/coremark/meson.build" }, { "type": "modify", "old_id": "3f32a0cab8d30cda345db6c61f3ff94cba883135", "old_mode": 33188, "old_path": "sw/device/examples/hello_usbdev/BUILD", "new_id": "60e4cd6edf42e1bf69e218f7d413ac267f980dc8", "new_mode": 33188, "new_path": "sw/device/examples/hello_usbdev/BUILD" }, { "type": "modify", "old_id": "3abac44db28c94f2631de2d58a486217811bc65d", "old_mode": 33188, "old_path": "sw/device/examples/hello_usbdev/meson.build", "new_id": "ffe5862acaa4869d3ddd97226ae8bc93c52c5321", "new_mode": 33188, "new_path": "sw/device/examples/hello_usbdev/meson.build" }, { "type": "modify", "old_id": "8c2947bc5c0bb79319be4e1a0e571542220a6466", "old_mode": 33188, "old_path": "sw/device/examples/hello_world/BUILD", "new_id": "80de6718adb716456e47021b512be7fd9fdf66fc", "new_mode": 33188, "new_path": "sw/device/examples/hello_world/BUILD" }, { "type": "modify", "old_id": "f26f62ec2ee192efc5903aadb327b0c8f0617afd", "old_mode": 33188, "old_path": "sw/device/examples/hello_world/meson.build", "new_id": "f5f40d13ad9defd971fb9829e9dd22b07c69334a", "new_mode": 33188, "new_path": "sw/device/examples/hello_world/meson.build" }, { "type": "modify", "old_id": "7062e72bfbd9bcae7cbd774c73746847382a86fd", "old_mode": 33188, "old_path": "sw/device/lib/testing/meson.build", "new_id": "bf870cfa50c690d58cbe3e77bba0ffa5b270ca7e", "new_mode": 33188, "new_path": "sw/device/lib/testing/meson.build" }, { "type": "modify", "old_id": "bbc309ea32f72785298bc620d8ab85974ee8ff99", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_framework/BUILD", "new_id": "bdeeaf031ebf7d390a19208d2f19ce32998acf1c", "new_mode": 33188, "new_path": "sw/device/lib/testing/test_framework/BUILD" }, { "type": "modify", "old_id": "33adaee7fa17ef38ce69fba1c095b7881973d232", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_framework/meson.build", "new_id": "c49285ca31da549dbe1f7b15127efc17b101bf33", "new_mode": 33188, "new_path": "sw/device/lib/testing/test_framework/meson.build" }, { "type": "modify", "old_id": "c5bdc55da302222b6c7e772472a92e3a230f6d54", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_framework/ottf.c", "new_id": "02ae16675c0895018c4f38e628bc336633d4e843", "new_mode": 33188, "new_path": "sw/device/lib/testing/test_framework/ottf.c" }, { "type": "rename", "old_id": "7be1be8f2e32514717c28b70ae445dc6b79f0c50", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_rom_ext/test_rom_ext.ld", "new_id": "d4d4ed9c9a96aba19349537abce32624c930d916", "new_mode": 33188, "new_path": "sw/device/lib/testing/test_framework/ottf.ld", "score": 96 }, { "type": "rename", "old_id": "462c44c3e94e1d1cf533925a002852392a6bdaf7", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_rom_ext/test_rom_ext_start.S", "new_id": "ae89cfcad01a2b90720276d33acec52f80ede4f8", "new_mode": 33188, "new_path": "sw/device/lib/testing/test_framework/ottf_start.S", "score": 89 }, { "type": "modify", "old_id": "b5e8c9ca6d2feb888a0a7cf8f2e0a6fe32b32e12", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_rom/meson.build", "new_id": "ad625eb95d3f12d22cc48204c62e53135b00b377", "new_mode": 33188, "new_path": "sw/device/lib/testing/test_rom/meson.build" }, { "type": "modify", "old_id": "9fdc2dab0d0c2f93ed3521d3310e8bfffaf84ac7", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_rom/test_rom.c", "new_id": "e66ec6fd3e15b4a5e49af4216d93566551f8f7e8", "new_mode": 33188, "new_path": "sw/device/lib/testing/test_rom/test_rom.c" }, { "type": "modify", "old_id": "a7785b5b147e0ad7fe6b7bbf36e853f5d26ba909", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_rom/test_rom.ld", "new_id": "b7a67cc997c7e6ef47ab63a38ce79dde545f1712", "new_mode": 33188, "new_path": "sw/device/lib/testing/test_rom/test_rom.ld" }, { "type": "delete", "old_id": "8fdae3dac5e0de5bdae24e501f4ed4a920ffc48e", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_rom_ext/BUILD", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "c6af3f1453389a13eca62874d02c5f20e7e2f841", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_rom_ext/empty.c", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "897a42076a6c8acb4bf255ee814d4803b229ef75", "old_mode": 33188, "old_path": "sw/device/lib/testing/test_rom_ext/meson.build", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "514adf1986cd96b7e6b5679257894e34ced61cfb", "old_mode": 33188, "old_path": "sw/device/riscv_compliance_support/meson.build", "new_id": "9b7fcb7fd1f3eaeee82ef8281421aa0e26611a33", "new_mode": 33188, "new_path": "sw/device/riscv_compliance_support/meson.build" }, { "type": "modify", "old_id": "c4a65f7e05a2eb7457a51aab6eb6d208b9e9b636", "old_mode": 33188, "old_path": "sw/device/sca/lib/meson.build", "new_id": "3a613b2b832199effa35eb1cf9d382d53ae63796", "new_mode": 33188, "new_path": "sw/device/sca/lib/meson.build" }, { "type": "modify", "old_id": "8fe38d404f92ef2ee916271fb795d482e10f806a", "old_mode": 33188, "old_path": "sw/device/sca/meson.build", "new_id": "7fc17f3df254332c655b47cc0da4ae3f4feae28a", "new_mode": 33188, "new_path": "sw/device/sca/meson.build" }, { "type": "modify", "old_id": "02025b36c245ac60342139e79c327926fbdb4d9f", "old_mode": 33188, "old_path": "sw/device/silicon_creator/mask_rom/meson.build", "new_id": "d0ef04efaa27f7b3a9948cd8c03aa452081b0d51", "new_mode": 33188, "new_path": "sw/device/silicon_creator/mask_rom/meson.build" }, { "type": "modify", "old_id": "45bf2dec1cb6da70b30b9b9e2240a428acd38ca6", "old_mode": 33188, "old_path": "sw/device/silicon_creator/rom_ext/meson.build", "new_id": "f5d1e3d48a8d0a5c4b4fffeaee49d4b703947981", "new_mode": 33188, "new_path": "sw/device/silicon_creator/rom_ext/meson.build" }, { "type": "modify", "old_id": "e1d6140a1a003e799b79f4c4ac0bdb8e60299e6c", "old_mode": 33188, "old_path": "sw/device/silicon_creator/testing/meson.build", "new_id": "13a501ada8f495f3180d6f83889e9291d4bb1c64", "new_mode": 33188, "new_path": "sw/device/silicon_creator/testing/meson.build" }, { "type": "modify", "old_id": "deca7333649dddedd49a94c8adfa020ae5cb9906", "old_mode": 33188, "old_path": "sw/device/silicon_owner/bare_metal/meson.build", "new_id": "f2d3a6ada265e72b05f1f11c3cb63572ad1e069c", "new_mode": 33188, "new_path": "sw/device/silicon_owner/bare_metal/meson.build" }, { "type": "modify", "old_id": "9653994aff761aff20e2f3483d946d393f5bd5a3", "old_mode": 33188, "old_path": "sw/device/tests/crt_test.c", "new_id": "011e2593eb84bebed0ed850eeae0675fc7cc61c7", "new_mode": 33188, "new_path": "sw/device/tests/crt_test.c" }, { "type": "modify", "old_id": "8e60b6e41ed342ea29f9ac6552c879e7806f31e3", "old_mode": 33188, "old_path": "sw/device/tests/meson.build", "new_id": "529f26e38333f5a8513ff6e405db6d12125022c9", "new_mode": 33188, "new_path": "sw/device/tests/meson.build" }, { "type": "modify", "old_id": "7581c99b09515576c9642aac35e7fe47a1dca1ab", "old_mode": 33188, "old_path": "sw/vendor/patches/riscv_compliance/0002-Add-OpenTitan-target.patch", "new_id": "02beca93b078aa8bc7a7831275e52609a6b630db", "new_mode": 33188, "new_path": "sw/vendor/patches/riscv_compliance/0002-Add-OpenTitan-target.patch" }, { "type": "modify", "old_id": "3f06cc70a67d1092500b77863e79107bf3b97337", "old_mode": 33188, "old_path": "sw/vendor/patches/riscv_compliance/0005-verilator-Rename-top_-chip_.patch", "new_id": "2c897fc6f82a3ed34ec72b595beaa721a41e21f4", "new_mode": 33188, "new_path": "sw/vendor/patches/riscv_compliance/0005-verilator-Rename-top_-chip_.patch" }, { "type": "modify", "old_id": "b3ddf1e0d53710c58291a0a678520dc10183ae61", "old_mode": 33188, "old_path": "sw/vendor/riscv_compliance/riscv-target/opentitan/device/rv32imc/Makefile.include", "new_id": "829cfd1be75da61462409fea1bcd5702f6501a3a", "new_mode": 33188, "new_path": "sw/vendor/riscv_compliance/riscv-target/opentitan/device/rv32imc/Makefile.include" } ] }