commit c951f9617e4f6640913c173881bab404aa4eef96
author Wyatt Hepler <hepler@google.com> Mon Jan 27 13:17:14 2020 -0800
committer Wyatt Hepler <hepler@google.com> Mon Jan 27 13:59:59 2020 -0800
tree 27a1025013f00d376de8782c62a0706922858777
parent 2ad60674783895299807359b6f5346a3853b3397

pw_log_basic: Add printf format checking

Use PW_PRINTF_FORMAT and fix an issue it exposes.

Change-Id: I382b301f893702f9410751295e99a958973480c4

pw_kvs/public/pw_kvs/flash_memory.h

diff --git a/pw_kvs/public/pw_kvs/flash_memory.h b/pw_kvs/public/pw_kvs/flash_memory.h
index d62f794..65799f0 100644
--- a/pw_kvs/public/pw_kvs/flash_memory.h
+++ b/pw_kvs/public/pw_kvs/flash_memory.h
@@ -319,7 +319,7 @@
   }
 
  protected:
-  Status CheckBounds(Address address, uint32_t len) const {
+  Status CheckBounds(Address address, size_t len) const {
     if (address + len > GetSizeBytes()) {
       PW_LOG_ERROR(
           "Attempted out-of-bound flash memory access (address: %" PRIu32

pw_log_basic/public/pw_log_basic/log_basic.h

diff --git a/pw_log_basic/public/pw_log_basic/log_basic.h b/pw_log_basic/public/pw_log_basic/log_basic.h
index b9a9e78..e820921 100644
--- a/pw_log_basic/public/pw_log_basic/log_basic.h
+++ b/pw_log_basic/public/pw_log_basic/log_basic.h
@@ -13,6 +13,7 @@
 // the License.
 #pragma once
 
+#include "pw_preprocessor/compiler.h"
 #include "pw_preprocessor/util.h"
 
 PW_EXTERN_C_START
@@ -25,7 +26,7 @@
             int line_number,
             const char* function_name,
             const char* message,
-            ...);
+            ...) PW_PRINTF_FORMAT(7, 8);
 
 PW_EXTERN_C_END